Ensure Process.ProcessName doesn't change when setting Thread.Name on Linux #19706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't compile and I can't look further right now so feel free to close. Unless you know the correct pattern to use |
|
@danmosemsft the CoreCLR side of the change simply casts the thread id to |
monojenkins
force-pushed
the
sync-pr-34064-from-runtime
branch
from
d6ed581 to
9c3fab9
Compare
… Linux Fixes dotnet/runtime#33673 This issue is a side-effect of adding support for setting thread names on Linux in dotnet/coreclr#27182. cc @janvorli @lpereira @SteveL-MSFT
monojenkins
force-pushed
the
sync-pr-34064-from-runtime
branch
from
9c3fab9 to
7fe6060
Compare
|
Implementing the correct fix is tracked by dotnet/runtime#35908. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#34064, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
Fixes dotnet/runtime#33673
This issue is a side-effect of adding support for setting thread names on Linux in dotnet/coreclr#27182.
cc @janvorli @lpereira @SteveL-MSFT