Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Update to the lastest from dotnet/toolset release/3.1xx #150

Merged
merged 39 commits into from
Oct 31, 2019
Merged

Update to the lastest from dotnet/toolset release/3.1xx #150

merged 39 commits into from
Oct 31, 2019

Conversation

lewing
Copy link
Member

@lewing lewing commented Oct 24, 2019

No description provided.

rainersigwald and others added 28 commits October 18, 2019 10:20
@rainersigwald
Restore write-resource-to-text tests
9aa42bb 
Closes #308 by re-enabling the tests.
@rainersigwald
Disable InvalidReference test on Core
86c74a5
@rainersigwald
Error when serializing resources to text
3a6da3e 
This was working for ResXResourceReader-based resources but not the new reader.
@Forgind
Unconditionally enable CodeDOM
d2046a2
@Forgind
Added overridable method after proc.Start() (dotnet#4814)
a9ce4fd 
* Added overridable method after proc.Start() to allow the user extra control over what happens without overwriting large methods.
@Forgind
Build test tasks at build time instead of CodeTaskFactory
65b17dc
@Forgind @rainersigwald
Altered VBLineSeparator format
05705e1 
This changes depending on OS, and the library we use shifts accordingly, so we should as well. This updates the "expected" value of the test so the test passes.

Co-Authored-By: rainersigwald <raines@microsoft.com>
@Forgind @rainersigwald
Shouldly assertion in WriteCodeFragment_Tests
0a78665 
Co-Authored-By: rainersigwald <raines@microsoft.com>
@rainersigwald
Support TestEnvironment in resx tests
a89802a
@rainersigwald
Failure-to-read-resources test is desktop only
bc04a15 
There are various failures possible in ReadResources, but the existing test applies only to full framework
@rainersigwald
Allow core-only tests
1de44ef 
Uses the existing category from Xunit.NetCore.Extensions
@rainersigwald
Localized error for can't-read-that-from-Core
60f260c 
These situations logged confusing English-only errors; now they fail and the error can get localized.
@Forgind
Make framework internals visible
f315ea9
@Forgind
Merge pull request dotnet#4837 from Forgind/framework-ivt
0a4fe0e 
Make framework internals visible
@dotnet-maestro @rainersigwald
[master] Update dependencies from dotnet/arcade (dotnet#4827)
f43d09d 
* Update dependencies from https://github.com/dotnet/arcade build 20191017.3

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19517.3
@rainersigwald
Restore setup-maestro-vars.ps1 (dotnet#4841)
62a87ea 
This was deleted in dotnet#4827 but that seems to be failing builds.
@rainersigwald
More-tolerant mscorlib type references (dotnet#4829)
321ea29 
Fixes dotnet#4773 by treating string and MemoryStream types as a prefix match on the mscorlib identity,
hoping to more closely match `Type.GetType`'s behavior.
@rainersigwald
Merge branch 'master' into remove-codedom-code
e060465
Adding xsd properties for AssetTargetFallback and Nullable. (dotnet#4840
72f86ff 
)

* Adding xsd properties for AssetTargetFallback and Nullable.

* Addressing code review comments.
@radical
[mono] Update SDKs to track release/3.1.1xx
1aee11f 
```
Microsoft.NET.Sdk.Web:                  3.1.100-preview2.19522.3
Microsoft.NET.Sdk.Razor:                3.1.0-preview2.19518.7

Microsoft.NETCore.App:                  3.1.0-preview2.19522.9
Microsoft.DotNet.Cli.Runtime:           3.1.100-preview2.19522.5

NuGet.Build.Tasks:                      5.4.0-preview.3.6271
```

Based on `dotnet/toolset` `release/3.1.1xx` branch HEAD
394d0ee
@radical
[mono] Update all_files.canon.txt
a605bca
@radical
[mono] Copy SdkVersions details to bindir
d1f47b4 
`eng/Version.Details.xml` which contains the SDK versions and commit
hashes, is copied as `SdkVersions.Details.xml`
@radical
[mono] Update all_files.canon.txt
d4e9337
@rainersigwald
Remove redundant delete in WriteTestResX
2c99582
@rainersigwald
Restore write-resource-to-text tests (dotnet#4830)
455f5be 
Closes #308
@Forgind
Create documentation on debugging on mac (dotnet#4825)
8aa2c23 
Create documentation on debugging on mac, including how to run a single test in isolation and see Console.WriteLine statements; how to run all tests in a class; how to run all tests; and how to identify, after running all tests, which had failed and why.
@Forgind
Merge pull request dotnet#4818 from Forgind/remove-codedom-code
1601b44 
Remove codedom code
@Forgind @rainersigwald
Microsoft-Build trace events (dotnet#4724)
21bad66 
* Replace CodeMarkers with EventSource

Replaced (outdated) CodeMarkers with EventSource to allow for easier profiling of events of importance.

Added LazyItemEvaluators to the cases we try to profile and altered the opt in to use an environment variable.

* Used Start/Stop in EventSource

Allows EventSource to automatically calculate time difference. I also switched from using an environment variable (MSBUILDENABLEPROFILING) to using EventSource's IsEnabled method.

* Added documentation for Eventing

Explanation of where, why, with what goals, and how MSBuild profiling now works, using EventSource.
@lewing lewing changed the title Update to the lastest from dotnet/toolset realease/3.1xx Update to the lastest from dotnet/toolset release/3.1xx Oct 24, 2019
@benvillalobos
Port XslTransformation to .NET Core (dotnet#4844)
229e612 
* Ensuring XslTransform is also built for netcore

* Also bring in the unit tests.

* Added new constant for compiled xsl

* Sectioned off non-netcore logic behind FEATURE_COMPILED_XSL

* Removed broken netcore tests

* Changes based on code review.

* Added proper logging

* Code review fix. Wording on error.
@akoeplinger
Copy link
Member

This seems to be stuck during building msbuild for some reason. I logged into the bot to look at the logs directly but couldn't find out why.

@radical
Copy link
Member

radical commented Oct 25, 2019

Add /m:1 to https://github.com/mono/msbuild/blob/xplat-master/eng/cibuild_bootstrapped_msbuild.sh#L87 and https://github.com/mono/msbuild/blob/xplat-master/eng/cibuild_bootstrapped_msbuild.sh#L119 . This is likely stuck because the second build uses the just built msbuild, which will now try to run a parallel build and is getting stuck. Best to debug this locally, but adding /m:1 will get you a package at least.

@radical
Copy link
Member

radical commented Oct 25, 2019

Yikes.. ignore that! I thought I was replying to the "enable parallel build" PR! note to self: don't reply in a hurry!

@radical
Copy link
Member

radical commented Oct 25, 2019

I would suggest adding /v:diag to get the diag log on the console, that might give us some hints.

@radical radical merged commit 55c4ca4 into mono-2019-08 Oct 31, 2019
@radical radical deleted the bump-toolset branch October 31, 2019 13:06
radical added a commit to radical/mono that referenced this pull request Oct 31, 2019
@radical
Bump msbuild to track mono-2019-08
e4bc1e0 
.. to get SDK updates from mono/msbuild#150 .
@radical radical mentioned this pull request Oct 31, 2019
Closed
radical added a commit to lewing/mono that referenced this pull request Oct 31, 2019
@radical
Bump msbuild to get SDK updates from mono/msbuild#150
f9c4a09
lewing pushed a commit to mono/mono that referenced this pull request Nov 1, 2019
@radical @lewing
Bump msbuild to get SDK updates from mono/msbuild#150
6d1f88e
VincentDondain added a commit to VincentDondain/xamarin-macios that referenced this pull request Nov 1, 2019
@VincentDondain
[d16-4] Bump mono 2019-08@e1ef7743
b8319bf 
New commits in mono/mono:

* mono/mono@e1ef774391d [2019-08] Bump CoreFX to pickup corefx PR xamarin#367 to fix xamarin#17133. (xamarin#17622)
* mono/mono@6d1f88e0ad2 Bump msbuild to get SDK updates from mono/msbuild#150
* mono/mono@a3f3bfc4c3d Bump nuget to the latest suggested version
* mono/mono@9bd3079f1ca [2019-08] bump msbuild with more p2 packages
* mono/mono@6ac1ff75a27 [dim][regression] Explicit interface override (xamarin#17583) (xamarin#17627)
* mono/mono@a119807a015 [acceptance-tests] Bump mono/roslyn to get build fix
* mono/mono@d234d34b700 [2019-08][merp] Install sigterm handler in EnableMicrosoftTelemetry
* mono/mono@444a9a3fc48 [2019-08] [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping (xamarin#17568)

Diff: https://github.com/mono/mono/compare/8946e49a974ea8b75fe5b8b7e93ffd4571521a85..e1ef774391da2b84d003431e8871b0bacbd25cb3
@VincentDondain VincentDondain mentioned this pull request Nov 1, 2019
Merged
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Nov 1, 2019
@jonpryor
Bump to mono/mono@e1ef7743
62bd87d 
Changes: mono/mono@8946e49...e1ef774

Context: mono/mono#17133

  * mono/mono@e1ef774391d: [2019-08] Bump CoreFX to pickup corefx PR dotnet#367 to fix #17133. (#17622)
  * mono/mono@6d1f88e0ad2: Bump msbuild to get SDK updates from mono/msbuild#150
  * mono/mono@a3f3bfc4c3d: Bump nuget to the latest suggested version
  * mono/mono@9bd3079f1ca: [2019-08] bump msbuild with more p2 packages
  * mono/mono@6ac1ff75a27: [dim][regression] Explicit interface override (#17583) (#17627)
  * mono/mono@a119807a015: [acceptance-tests] Bump mono/roslyn to get build fix
  * mono/mono@d234d34b700: [2019-08][merp] Install sigterm handler in EnableMicrosoftTelemetry
  * mono/mono@444a9a3fc48: [2019-08] [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping (#17568)
@jonpryor jonpryor mentioned this pull request Nov 1, 2019
Merged
rolfbjarne pushed a commit to xamarin/xamarin-macios that referenced this pull request Nov 4, 2019
@VincentDondain @rolfbjarne
[d16-4] Bump mono 2019-08@e1ef7743 (#7356)
898ea3c 
New commits in mono/mono:

* mono/mono@e1ef774391d [2019-08] Bump CoreFX to pickup corefx PR #367 to fix #17133. (#17622)
* mono/mono@6d1f88e0ad2 Bump msbuild to get SDK updates from mono/msbuild#150
* mono/mono@a3f3bfc4c3d Bump nuget to the latest suggested version
* mono/mono@9bd3079f1ca [2019-08] bump msbuild with more p2 packages
* mono/mono@6ac1ff75a27 [dim][regression] Explicit interface override (#17583) (#17627)
* mono/mono@a119807a015 [acceptance-tests] Bump mono/roslyn to get build fix
* mono/mono@d234d34b700 [2019-08][merp] Install sigterm handler in EnableMicrosoftTelemetry
* mono/mono@444a9a3fc48 [2019-08] [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping (#17568)

Diff: https://github.com/mono/mono/compare/8946e49a974ea8b75fe5b8b7e93ffd4571521a85..e1ef774391da2b84d003431e8871b0bacbd25cb3
jonpryor added a commit to dotnet/android that referenced this pull request Nov 5, 2019
@jonpryor
Bump to mono/mono@e1ef7743 (#3872)
5e2fd06 
Changes: mono/mono@8946e49...e1ef774

Context: mono/mono#17133

  * mono/mono@e1ef774391d: [2019-08] Bump CoreFX to pickup corefx PR #367 to fix #17133. (#17622)
  * mono/mono@6d1f88e0ad2: Bump msbuild to get SDK updates from mono/msbuild#150
  * mono/mono@a3f3bfc4c3d: Bump nuget to the latest suggested version
  * mono/mono@9bd3079f1ca: [2019-08] bump msbuild with more p2 packages
  * mono/mono@6ac1ff75a27: [dim][regression] Explicit interface override (#17583) (#17627)
  * mono/mono@a119807a015: [acceptance-tests] Bump mono/roslyn to get build fix
  * mono/mono@d234d34b700: [2019-08][merp] Install sigterm handler in EnableMicrosoftTelemetry
  * mono/mono@444a9a3fc48: [2019-08] [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping (#17568)
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Nov 12, 2019
@jonpryor
Bump to mono/mono@062f0ab8
187e5e3 
Changes: mono/mono@8946e49...062f0ab

Context: mono/mono#17133

  * mono/mono@062f0ab: [sdks] Use Xcode 11.2 stable version for iOS/Mac SDKs
  * mono/mono@e1ef774: [2019-08] Bump CoreFX to pickup corefx PR dotnet#367 to fix #17133. (#17622)
  * mono/mono@6d1f88e: Bump msbuild to get SDK updates from mono/msbuild#150
  * mono/mono@a3f3bfc: Bump nuget to the latest suggested version
  * mono/mono@9bd3079: [2019-08] bump msbuild with more p2 packages
  * mono/mono@6ac1ff7: [dim][regression] Explicit interface override (#17583) (#17627)
  * mono/mono@a119807: [acceptance-tests] Bump mono/roslyn to get build fix
  * mono/mono@d234d34: [2019-08][merp] Install sigterm handler in EnableMicrosoftTelemetry
  * mono/mono@444a9a3: [2019-08] [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping (#17568)
@jonpryor jonpryor mentioned this pull request Nov 12, 2019
Merged
jonpryor added a commit to dotnet/android that referenced this pull request Nov 12, 2019
@jonpryor
Bump to mono/mono@062f0ab8 (#3901)
07c48e6 
Changes: mono/mono@8946e49...062f0ab

Context: mono/mono#17133

  * mono/mono@062f0ab: [sdks] Use Xcode 11.2 stable version for iOS/Mac SDKs
  * mono/mono@e1ef774: [2019-08] Bump CoreFX to pickup corefx PR #367 to fix #17133. (#17622)
  * mono/mono@6d1f88e: Bump msbuild to get SDK updates from mono/msbuild#150
  * mono/mono@a3f3bfc: Bump nuget to the latest suggested version
  * mono/mono@9bd3079: [2019-08] bump msbuild with more p2 packages
  * mono/mono@6ac1ff7: [dim][regression] Explicit interface override (#17583) (#17627)
  * mono/mono@a119807: [acceptance-tests] Bump mono/roslyn to get build fix
  * mono/mono@d234d34: [2019-08][merp] Install sigterm handler in EnableMicrosoftTelemetry
  * mono/mono@444a9a3: [2019-08] [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping (#17568)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lewing @akoeplinger @radical @rainersigwald @Forgind @benvillalobos