Fix assembly load priorities when using AssemblyLoadContext #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior should now be equivalent to that of the AppDomain codepath: assemblies are loaded from referenced assembly paths only after failing to resolve them from loaded assemblies in the host context and after the runtime fails to resolve them from the default context.
The list of assembly files referenced by the template may contain reference assemblies, which will fail to load. Letting the host attempt to resolve the assembly first gives it an opportunity to resolve runtime assemblies. Ideally we would have a robust mechanism for resolving runtime assemblies bue this will have to serve as a stopgap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change assembly load behavior when using
AssemblyLoadContextto match the behavior when usingAppDomain.Assemblies are now loaded from explicitly referenced assembly paths only after failing to resolve them from loaded assemblies in the host context and after the runtime fails to resolve them from the default context.
Also, when resolving assemblies, give the host
ResolveAssemblyReferencepriority over the list of explicitly referenced assembly paths, as a stopgap to allow it to resolve runtime assemblies when the list contains reference assemblies.This may be a fix for the underlying issue of dotnet/efcore#32385 but I'm not sure I'm confident to backport it to 2.3.x.