Add field names to pallet Event variants

[warfollowsme]

Description

This PR changes/added:

• pallet events variants from tuples to structs with named fields;
• descriptions for some events.

After PR#9896 was merged events can now be described with field names.

These field names and their respective comments are in turn reflected in the metadata for a better client experience.

[crystalin]

@warfollowsme Thank you for your contribution, it looks good.
Can you cargo fmt the code please ?

[warfollowsme]

@crystalin Do I need fixed all diffs from the build log too?

[librelois]

@crystalin Do I need fixed all diffs from the build log too?

No need to fix them manually, you just need to run cargo fmt :)

[warfollowsme]

No need to fix them manually, you just need to run cargo fmt :)

okay. done. :)

[warfollowsme]

Okay. I realized that I completely forgot to change the use of events in tests.

[warfollowsme]

build workflow is done. what should I do to fix the typescript tests?

[librelois]

build workflow is done. what should I do to fix the typescript tests?

You probably just need to merge master

[warfollowsme]

You probably just need to merge master

Okay. Only docker compile left. Issues with login. How can I fix it?
Also, these workflows are not required, perhaps you can merge PR.

[librelois]

Okay. Only docker compile left. Issues with login. How can I fix it? Also, these workflows are not required, perhaps you can merge PR.

You can't fix it, we need to skip theses jobs for external PRs. @crystalin can you merge this PR ?

[crystalin]

@librelois if this is inconsistent with our other pallets, I'd prefer to have them all included the same format before merging it (to avoid having multiple breaking changes release) what do you think ?

[crystalin]

Actually, does it impact the clients (polkadotJS UI or SDK) ? It doesn't seem so looking at the file changed. if not I'll merge it

[librelois]

@librelois if this is inconsistent with our other pallets, I'd prefer to have them all included the same format before merging it (to avoid having multiple breaking changes release) what do you think ?

We have a lot of events with unnamed fields (basically everywhere…), I think it would be a too big PR to change everything at once, it's better to do it in several times :)

[librelois]

Actually, does it impact the clients (polkadotJS UI or SDK) ? It doesn't seem so looking at the file changed. if not I'll merge it

I know that polkadotjs is not impacted, for the rest I don't know

[crystalin]

Merging, thank you @warfollowsme for your contribution