Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch jsonrpsee: allow unknown fields in json requests #1777

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

librelois
Copy link
Collaborator

What does it do?

Patch jsonrpsee to include paritytech/jsonrpsee#803

We need this to support cuistom fields in RPC requests, like skipCache.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Aug 24, 2022
Copy link
Collaborator

@crystalin crystalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to keep those in master ?

@librelois
Copy link
Collaborator Author

Are we planning to keep those in master ?

Until a substrate dependency upgrade that bump jsonrpsee to v0.15

@librelois librelois merged commit 363761c into master Aug 24, 2022
@librelois librelois deleted the elois-patch-jsonrpsee branch August 24, 2022 13:35
@niklasad1
Copy link

FYI: polkadot-v0.9.28 will have jsonrpsee v0.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants