Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.9.29 Dependency Update #1825

Merged
merged 71 commits into from
Oct 6, 2022
Merged

v0.9.29 Dependency Update #1825

merged 71 commits into from
Oct 6, 2022

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Sep 21, 2022 •
edited
Loading

What does it do?

Updates Moonbeam and friends to the Polkadot v0.9.29 release. "Fixes" #1814

⚠️ Breaking Changes ⚠️

⚠️ CLI parameters --keep-blocks and --pruning changed paritytech/substrate#11934
⚠️ Weights are now a struct instead of a u64
⚠️ 🐛 pays_fee is now properly recorded and reflected in APIs. This means that some extrinsics (including Ethereum txns) and inherents will now correctly report pays_fee: No or paysFee: false whereas they incorrectly reported Yes previously. paritytech/substrate#11849
🎉 try-runtime::follow-chain gets a --keep-connection flag: paritytech/substrate#12167
🎉 Caching should be usable: paritytech/substrate#11407

TODO

notlesh
notlesh commented Sep 21, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
notlesh
notlesh commented Sep 21, 2022
View reviewed changes
rust-toolchain Outdated Show resolved Hide resolved
@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. dependencies Pull requests that update a dependency file labels Sep 22, 2022
notlesh
notlesh commented Oct 3, 2022
View reviewed changes
tests/util/block.ts Outdated Show resolved Hide resolved
notlesh
notlesh commented Oct 4, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@notlesh notlesh added the A0-pleasereview Pull request needs code review. label Oct 5, 2022
girazoki
girazoki approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see anything fundamentally wrong. I will keep reviewing the PRs you noted above though

@crystalin
Copy link
Collaborator

@notlesh I don't see the payFees::no change of Frontier in the breaking changes of this PR

@tgmichel
Copy link
Contributor

tgmichel commented Oct 6, 2022

@notlesh with the inclusion of moonbeam-foundation/frontier@fe12fdd we need to bump web3 js version to ^1.8.0 that supports the new safe and finalized block tags. Rel #1831

@notlesh notlesh merged commit 93698c5 into master Oct 6, 2022
@notlesh notlesh deleted the moonbeam-polkadot-v0.9.29 branch October 6, 2022 14:23
@notlesh notlesh mentioned this pull request Oct 11, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4meta5 4meta5 4meta5 left review comments

@nanocryk nanocryk nanocryk left review comments

@kianenigma kianenigma kianenigma left review comments

@tgmichel tgmichel tgmichel left review comments

@librelois librelois librelois approved these changes

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@notlesh @librelois @crystalin @tgmichel @kianenigma @nanocryk @girazoki @4meta5