Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect eth parent hashes on moonbase #2524

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix incorrect eth parent hashes on moonbase #2524

merged 3 commits into from
Oct 17, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Oct 16, 2023 •
edited
Loading

What does it do?

Fixes incorrect eth parent hash for the block 1648995 on moonbase that is retrieving via RPC. No other blocks were found with the same issue.

What important points reviewers should know?

This isn't being applied for --dev mode.

See context:

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes labels Oct 16, 2023
@nbaztec nbaztec changed the title fix incorrect parent hashes fix incorrect parent hashes on moonbase Oct 16, 2023
@nbaztec nbaztec changed the title fix incorrect parent hashes on moonbase fix incorrect eth parent hashes on moonbase Oct 16, 2023
@github-actions
Copy link
Contributor

Coverage generated "Mon Oct 16 10:02:37 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2524/html/index.html

Master coverage: 87.39%
Pull coverage:

noandrea
noandrea approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbaztec nbaztec merged commit 6c7c10b into master Oct 17, 2023
31 checks passed
@nbaztec nbaztec deleted the nish-fix-parent-hash branch October 17, 2023 08:17
rimbi pushed a commit that referenced this pull request Oct 18, 2023
@nbaztec
fix incorrect eth parent hashes on moonbase (#2524)
22616e0 
* fix incorrect parent hashes

* apply to moonbase

* use correct block hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noandrea noandrea noandrea approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbaztec @noandrea