-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XCM-Transactor] Make fee_payer
field optional in transact_through_sovereign
#2709
Conversation
…ides not being loaded
Coverage Report@@ Coverage Diff @@
## master agustin-fee-payer-field +/- ##
===========================================================
- Coverage 72.51% 72.50% -0.01%
Files 229 229
+ Lines 70565 70651 +86
===========================================================
+ Hits 51164 51219 +55
+ Misses 19401 19432 +31
|
…agustin-fee-payer-field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets only merge it after #2700 and after changing the target branch to master
.
Lets have this change rebased with master, you can create a new PR if you want to avoid a force push. |
Already rebased without force pushes :) |
What does it do?
Changes
fee_payer
field type fromT::AccountId
toOption<T::AccountId>
. This allows root origin to avoid specifying a fee payer when executingtransact_through_sovereign
function ofpallet-xcm-transactor
.If
fee_payer
is set toNone
, the XCM execution fees will be paid by the sovereign account on the destination chain.Note
It's important to properly fund the sovereign account on destination with the corresponding amount that will be used to pay for execution fees, otherwise the call will fail or also there could be some funds mismatch.