Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCM-Transactor] Make fee_payer field optional in transact_through_sovereign #2709

Merged
merged 79 commits into from
Mar 27, 2024

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Mar 19, 2024

What does it do?

Changes fee_payer field type from T::AccountId to Option<T::AccountId>. This allows root origin to avoid specifying a fee payer when executing transact_through_sovereign function of pallet-xcm-transactor.

If fee_payer is set to None, the XCM execution fees will be paid by the sovereign account on the destination chain.

Note

It's important to properly fund the sovereign account on destination with the corresponding amount that will be used to pay for execution fees, otherwise the call will fail or also there could be some funds mismatch.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

Coverage Report

@@                     Coverage Diff                     @@
##           master   agustin-fee-payer-field      +/-   ##
===========================================================
- Coverage   72.51%                    72.50%   -0.01%     
  Files         229                       229              
+ Lines       70565                     70651      +86     
===========================================================
+ Hits        51164                     51219      +55     
+ Misses      19401                     19432      +31     
Files Changed Coverage
/pallets/moonbeam-lazy-migrations/src/lib.rs 58.33% (-29.17%) 🔽

Coverage generated Wed Mar 27 13:01:01 UTC 2024

pallets/xcm-transactor/src/tests.rs Show resolved Hide resolved
pallets/xcm-transactor/src/tests.rs Show resolved Hide resolved
Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets only merge it after #2700 and after changing the target branch to master.

Base automatically changed from rq/update-polkadot-v1.7.2 to master March 26, 2024 14:27
@RomarQ
Copy link
Contributor

RomarQ commented Mar 27, 2024

Lets have this change rebased with master, you can create a new PR if you want to avoid a force push.

@Agusrodri
Copy link
Contributor Author

Lets have this change rebased with master, you can create a new PR if you want to avoid a force push.

Already rebased without force pushes :)

@Agusrodri Agusrodri merged commit f0f498b into master Mar 27, 2024
27 checks passed
@Agusrodri Agusrodri deleted the agustin-fee-payer-field branch March 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants