Add pallet-invulnerables (#163) #221
Conversation
|
@rimbi Can you provide a description of what the PR does? |
| use sp_std::prelude::*; | ||
|
|
||
| pub struct MigrateToV1<T>(sp_std::marker::PhantomData<T>); | ||
| impl<T: Config> OnRuntimeUpgrade for MigrateToV1<T> { |
There was a problem hiding this comment.
I dont understand this migraiton. At the beginning there wont be any invulnerables. What we need to do is set them for the first time, but that has nothing to do with the storage version of the pallet (as it did not change). You can remove this fiole for now, as we need to do the migration in some other way
There was a problem hiding this comment.
I assumed we would work on it together. You can ignore it for now.
|
At some point I think it might be good to offer this pallet-abstraction to cumulus, leaving this comment here to remember :) |
rimbi
force-pushed
the
cem-pallet-invulnerables
branch
from
ed4a023
to
9263b47
Compare
rimbi
force-pushed
the
cem-pallet-invulnerables
branch
2 times, most recently
from
1d5e498
to
bdb2040
Compare
| }) | ||
| .build() | ||
| .execute_with(|| { | ||
| let invulnerables_collator_selection = CollatorSelection::invulnerables(); |
There was a problem hiding this comment.
One suggestion now that we got this test working: remove the
.with_collators(vec![
(AccountId::from(ALICE), 210 * UNIT),
(AccountId::from(BOB), 100 * UNIT),
])
and use put_storage_value like in https://github.com/moonbeam-foundation/moonbeam/blob/446faeb04153d127211a499244c900a1a5c71e54/pallets/asset-manager/src/tests.rs#L468. That way we are ready to remove the CollatorSelection in the following PR without having to change the test
rimbi
force-pushed
the
cem-pallet-invulnerables
branch
from
6addca3
to
0ff7bec
Compare
* Add pallet-invulnerables * Update api-augment interfaces * Update migration * Fix try-runtime build * Rename migration variable * Rename the migration * Fix the build problem with try-runtime feature * Add logging to runtime upgrade functions * Add integration test for invulnerables migration * Remove the explicit use of CollatorSelection in the integration test * Remove the explicit use of CollatorSelection in the migration * Fix typo * Populate the invulnerables w/o using CollatorSelection pallet
This pallet mimics what we do in collator-selection:
We would also need to include a migration to migrate those invulnerables from pallet-collator-selection to pallet-invulnerables.