-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional account as container chain manager #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgamundi
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
labels
May 9, 2024
tmpolaczyk
reviewed
May 9, 2024
tmpolaczyk
reviewed
May 9, 2024
tmpolaczyk
reviewed
May 9, 2024
Coverage Report@@ Coverage Diff @@
## master fg-chain-manager +/- ##
====================================================
- Coverage 69.53% 69.46% -0.07%
Files 221 221
+ Lines 38452 38524 +72
====================================================
+ Hits 26736 26760 +24
+ Misses 11716 11764 +48
|
girazoki
reviewed
May 15, 2024
tmpolaczyk
reviewed
May 17, 2024
tmpolaczyk
approved these changes
May 20, 2024
merge master back in @fgamundi please! |
girazoki
approved these changes
May 20, 2024
fgamundi
force-pushed
the
fg-chain-manager
branch
from
May 21, 2024 10:45
6c113b3
to
5a0cebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the container chain registrar creator to assign a separate account as the only valid manager for that chain in Tanssi.
On chain registration the manager will be set to the creator, and then only the creator can set a new manager.