Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional account as container chain manager #546

Merged
merged 17 commits into from
May 21, 2024
Merged

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented May 9, 2024

Allows the container chain registrar creator to assign a separate account as the only valid manager for that chain in Tanssi.
On chain registration the manager will be set to the creator, and then only the creator can set a new manager.

@fgamundi fgamundi added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels May 9, 2024
@fgamundi fgamundi self-assigned this May 9, 2024
@fgamundi fgamundi marked this pull request as ready for review May 9, 2024 10:27
Copy link
Contributor

github-actions bot commented May 9, 2024

Coverage Report

(master)

@@                 Coverage Diff                  @@
##           master   fg-chain-manager      +/-   ##
====================================================
- Coverage   69.53%             69.46%   -0.07%     
  Files         221                221              
+ Lines       38452              38524      +72     
====================================================
+ Hits        26736              26760      +24     
+ Misses      11716              11764      +48     
Files Changed Coverage
/pallets/registrar/src/lib.rs 90.07% (-0.57%) 🔽
/pallets/registrar/src/weights.rs 35.27% (-3.08%) 🔽
/runtime/common/src/migrations.rs 46.15% (-3.85%) 🔽

Coverage generated Tue May 21 11:24:03 UTC 2024

@fgamundi fgamundi requested a review from girazoki May 20, 2024 10:05
@girazoki
Copy link
Collaborator

merge master back in @fgamundi please!

@fgamundi fgamundi merged commit 5a445e6 into master May 21, 2024
32 checks passed
@fgamundi fgamundi deleted the fg-chain-manager branch May 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants