Stream payment: Prevent making a request with a past deadline #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
a0-pleasereview
Coverage Report@@ Coverage Diff @@
## master jeremy-steam-payment-no-past-deadline +/- ##
=========================================================================
+ Coverage 69.60% 69.61% +0.01%
Files 226 226
+ Lines 40210 40221 +11
=========================================================================
+ Hits 27988 27996 +8
+ Misses 12222 12225 +3
|
|
Thank you @nanocryk , let's fix dev tests and merge |
girazoki
approved these changes
Jun 19, 2024
tmpolaczyk
approved these changes
Jun 20, 2024
…t-no-past-deadline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents making a request with a mandatory change having a deadline in the past.
Also fix the
stream_payment_statusfunction to returnstalled = truewhen deadline is reached.