-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core assignation wired to collatorAssignment #629
Merged
girazoki
merged 55 commits into
master
from
wiring-core-assignation-with-collator-assignment
Aug 7, 2024
Merged
Core assignation wired to collatorAssignment #629
girazoki
merged 55 commits into
master
from
wiring-core-assignation-with-collator-assignment
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-with-collator-assignment
…tion-with-collator-assignment
girazoki
added
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
labels
Jul 19, 2024
…tion-with-collator-assignment
Coverage Report@@ Coverage Diff @@
## master wiring-core-assignation-with-collator-assignment +/- ##
====================================================================================
+ Coverage 65.95% 66.11% +0.16%
Files 263 263
+ Lines 45208 45754 +546
====================================================================================
+ Hits 29813 30246 +433
+ Misses 15395 15508 +113
|
…tion-with-collator-assignment
…tion-with-collator-assignment
tmpolaczyk
reviewed
Jul 31, 2024
solo-chains/runtime/starlight/src/tests/core_scheduling_tests.rs
Outdated
Show resolved
Hide resolved
tmpolaczyk
reviewed
Aug 1, 2024
girazoki
commented
Aug 2, 2024
solo-chains/runtime/starlight/src/tests/core_scheduling_tests.rs
Outdated
Show resolved
Hide resolved
tmpolaczyk
approved these changes
Aug 2, 2024
…tion-with-collator-assignment
ParthDesai
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes core-time traces and uses instead collator-assignation as a source of truth to assign cores. Currently the way it works is:
0..n-1
cores, wheren
is the number of parachains served for this sessionconfiguration.num_cores
In order to seamlessly test this, I had to add the possibility of registering a parachain and invulnerables (collators) from genesis in the tanssi-registrar. Now you can see this works by running the appropriate zombienet suite.
Important: this only works because
Whenever we constrcut the solo-chain aware collator node, this will fail. We will need an alternative solution for being able to inject the collator keys at genesis.
Todos for this PR:
[x] Rust integration tests