Update polkadot-sdk to stable2407 #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
added
breaking
Coverage Report@@ Coverage Diff @@
## master upgrade-stable2407 +/- ##
======================================================
+ Coverage 66.19% 66.49% +0.30%
- Files 264 261 -3
- Lines 45952 45854 -98
======================================================
+ Hits 30414 30490 +76
- Misses 15538 15364 -174
|
tmpolaczyk
commented
Aug 7, 2024
We don't need an extra migration to kill storage of the If you check the chain state of the different networks (Dancebox, Flashbox), you will notice that the |
Agusrodri
previously approved these changes
Aug 16, 2024
test/suites/common-tanssi/pallet-treasury/test_pallet_treasury.ts
Outdated
Show resolved
Hide resolved
test/suites/common-tanssi/pallet-treasury/test_pallet_treasury.ts
Outdated
Show resolved
Hide resolved
girazoki
reviewed
Aug 19, 2024
container-chains/runtime-templates/simple/src/weights/pallet_balances.rs
Show resolved
Hide resolved
girazoki
reviewed
Aug 19, 2024
girazoki
reviewed
Aug 19, 2024
Ok that's very smart, thanks for checking @Agusrodri |
ParthDesai
reviewed
Aug 20, 2024
ParthDesai
reviewed
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
NativeElseWasmExecutor has been deprecated, but we will keep using it for now. Removing it implies not being able to debug runtimes using breakpoints anymore.
cumulus-pallet-dmp-queue has been deprecated, it is safe to remove so we removed it. No need to kill pallet storage because it is automatically done in on_idle when migration completes.
pallet_treasury: proposeSpend and approveSpend have been removed. Instead of ApproveOrigin = Root and SpendOrigin = Never, we now have SpendOrigin = Root. In tests, users can no longer propose treasury spends, only root can spend. So I removed most of the treasury tests and added some new ones, please review that (test/suites/common-tanssi/pallet-treasury/test_pallet_treasury.ts). Info about the removal: paritytech/polkadot-sdk#138
Changed branch format in polkadot-sdk. Instead of "release-polkadot-v1.11.0", the release branch is now just called "stable2407". Our fork branch is called "tanssi-polkadot-stable2407" instead of "tanssi-polkadot-v1.11.0". I had to fix the download-polkadot.sh script, maybe other tools will break. More info:
https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2407
https://github.com/paritytech/polkadot-sdk/blob/master/docs/RELEASE.md