ServicesPayment in Starlight runtime #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report@@ Coverage Diff @@
## master fg-services-payment-starlight +/- ##
=================================================================
+ Coverage 66.11% 66.19% +0.08%
+ Files 263 264 +1
+ Lines 45754 45952 +198
=================================================================
+ Hits 30246 30414 +168
+ Misses 15508 15538 +30
|
fgamundi
changed the title
fgamundi
added
B7-runtimenoteworthy
|
zombie_tanssi_relay tests are failing because parachain 1000 is not producing blocks. Maybe it doesn't have credits? |
|
@tmpolaczyk it's passing now |
tmpolaczyk
reviewed
Aug 8, 2024
tmpolaczyk
reviewed
Aug 8, 2024
| ```bash | ||
| STARLIGHT_EPOCH_DURATION=10 ./polkadot/scripts/build-only-wasm.sh starlight-runtime /path/to/output/directory/ | ||
| ./polkadot/scripts/build-only-wasm.sh starlight-runtime /path/to/output/directory/ |
There was a problem hiding this comment.
I removed this so EpochDurationInBlocks could be a const, so FreeCollatorAssignmentCredits could also be a const. It wasn't needed, but I didn't see any place where we were using this env variable that came from Rococo.
tmpolaczyk
approved these changes
Aug 9, 2024
ParthDesai
reviewed
Aug 13, 2024
| XcmCoreBuyer::para_deregistered(para_id); | ||
| */ | ||
| ServicesPayment::para_deregistered(para_id); | ||
|
|
||
| Weight::default() |
There was a problem hiding this comment.
It seems we are not using this returned weight. Plus the pallet specific handlers also not returning Weight, Can we remove this in future PRs?
ParthDesai
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ServicePaymentpallet to Starlight runtime. This also enables service charging on collator assignment, free credits on registration and removal of assignment on insufficient credits.