MIP-X10 #441
Merged
MIP-X10 #441
+272
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anajuliabit @ElliotFriedman If I try to generate calldata locally via I get the following error for Moonbeam xcDOT: If I remove the mxcDOT entry from the json, I am able to generate the calldata without issues. Could you please advise? |
proposals/mips/mip-x09/x09.json
Outdated
| { | ||
| "collateralFactor": -1, | ||
| "irm": "", | ||
| "market": "mxcDOT", |
There was a problem hiding this comment.
because this uses a precompile, interacting with it causes problems. normally when we interact with contracts like that, we etch over them using the etch utils file
There was a problem hiding this comment.
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
|
@rsrizvi explanation is now part of the PR in docs https://github.com/moonwell-fi/moonwell-contracts-v2/pull/442/files#diff-80361b7ff2120bbca2235b8af6d1a800068557380d3619497694b0f91bcc4c99 |
|
TLDR is we aren't changing any of the proposal code that you wrote, just etching over precompile contracts on Moonbeam so the proposal doesn't fail due to a faulty simulation that reverts whenever it calls the GLMR, USDC, or xcDOT contracts. |
proposals/mips/mip-x09/x09.json
Outdated
| "10": { | ||
| "markets": [ | ||
| { | ||
| "collateralFactor": 0.1e18, |
There was a problem hiding this comment.
confirming we are dropping CF for wBTC on Optimism to 10%
proposals/mips/mip-x09/x09.json
Outdated
| { | ||
| "collateralFactor": -1, | ||
| "irm": "", | ||
| "market": "mxcDOT", |
There was a problem hiding this comment.
Co-authored-by: Elliot <34463580+ElliotFriedman@users.noreply.github.com>
|
@ElliotFriedman Please merge your referenced PR, then I will pull master, push, and also regenerate the calldata |
etch in market update
MIP-X10
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
|
|
ElliotFriedman
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.