Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stub not created #66

Merged
merged 5 commits into from
Jan 25, 2023

Conversation

badetitou
Copy link
Member

fix #61

When not using -i, we enable the jdt option setBindingsRecovery(true);
that allows us to resolve elements without binding.

@badetitou badetitou changed the title begin work on #61 Fix stub not created Jan 25, 2023
@badetitou
Copy link
Member Author

In this PR I have

  • Refactor the code to extract the method extractModifierOfTypeFrom to organize the code better
  • Improve the method asException to build a new Exception concept only if the parameter is not an Exception yet
  • Change ensureImplementedInterfaces to use ensureFamixInterface instead of ensureFamixType.
    • This modification is an optimization of the code, and fixes problems when using the AST parser with setBindingsRecovery(true);
  • Set jdtParser.setBindingsRecovery(true); when incrementalParsing is not activated
  • Fix an import in the test_src by adding the class Book in the test_src ad_hoc.annotations

With this PR, apart from issue #61,

  • we are now also able to extract Annotations not define in the classpath
  • We better deal with Exception

@NicolasAnquetil NicolasAnquetil merged commit eae3cc5 into v3 Jan 25, 2023
@NicolasAnquetil NicolasAnquetil deleted the fix-61-stub-not-created-superclass-interface branch January 25, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stub not created when extending/implementing external class/interface
2 participants