refactor: remove unused function parameters and correct redundant conditions #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alovak
approved these changes
Sep 3, 2024
|
By merging this pull request, the following pull requests will pass their CI checks :-) |
|
@alovak Thank you for the review. Another maintainer approve was needed to merge. Could you please inform the maintainer? |
adamdecaf
reviewed
Sep 25, 2024
connection.go
Outdated
| @@ -454,7 +454,7 @@ func (c *Connection) Send(message *iso8583.Message, options ...Option) (*iso8583 | |||
| return resp, err | |||
| } | |||
|
|
|||
| func (c *Connection) writeMessage(w io.Writer, message *iso8583.Message) error { | |||
| func (c *Connection) writeMessage(_ io.Writer, message *iso8583.Message) error { | |||
There was a problem hiding this comment.
Why is w passed in if it's not used?
There was a problem hiding this comment.
Thank you for pointing that out. I thought it was necessary to comply with the MessageWriter interface, so I decided that it would be better not to introduce any breaking changes, but that was a mistake. Originally, it seems that the argument w was being passed to WriteMessage, which was being used internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused function parameters and corrected redundant conditions.