Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend MTI enum #153

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Extend MTI enum #153

merged 5 commits into from
Dec 8, 2021

Conversation

louisheath
Copy link
Contributor

@louisheath louisheath commented Dec 7, 2021

Adds new enum values and minorly amends some comments.
Enum names and descriptions are derived from the Mastercard CIS as well as the generic ISO 8583 wiki page.

0180 - Authorisation Positive Acknowledgement
0190 - Authorisation Negative Acknowledgement
0410 - Reversal Request Response
0600 - Administrative Request
0610 - Administrative Request Response
0620 - Administrative Advice
0630 - Administrative Advice Response

@louisheath louisheath changed the title Add Reversal Request Response 0410 to MTI enum Add 0180, 0190 and 0410 to MTI enum Dec 7, 2021
@louisheath louisheath marked this pull request as draft December 7, 2021 14:58
@louisheath louisheath changed the title Add 0180, 0190 and 0410 to MTI enum Extend MTI enum Dec 7, 2021
@louisheath louisheath marked this pull request as ready for review December 7, 2021 18:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (4a2a193) to head (021a97e).
Report is 141 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   70.54%   70.54%           
=======================================
  Files          37       37           
  Lines        1633     1633           
=======================================
  Hits         1152     1152           
  Misses        308      308           
  Partials      173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak alovak merged commit 605da49 into moov-io:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants