Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on unpack nil #161

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Fix panic on unpack nil #161

merged 2 commits into from
Feb 9, 2022

Conversation

alovak
Copy link
Contributor

@alovak alovak commented Feb 9, 2022

In this PR we check input slice length before working with it to avoid panic errors: slice bounds out of range.

solves #159

@alovak alovak mentioned this pull request Feb 9, 2022
Closed
@alovak alovak requested a review from adamdecaf February 9, 2022 16:59
peterebden
peterebden reviewed Feb 9, 2022
View reviewed changes
Copy link

@peterebden peterebden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

encoding/ascii.go Outdated Show resolved Hide resolved
@alovak alovak merged commit 07d52aa into master Feb 9, 2022
@alovak alovak deleted the fix-panic-on-unpack-nil branch February 9, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterebden peterebden peterebden left review comments

@adamdecaf adamdecaf adamdecaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alovak @adamdecaf @peterebden