Make gokogiri compile with go 1.6 #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 17, 2016 13:26
So we only check X == Y where * X is the version we are compiled against * Y is the version we are dynamically linked against on startup
by passing the callback argument (a Go pointer) via global variable. This allows only one SetContent to happen at any time in the program, but works for now.
by passing the WriteBuffer in a global variable
since callbacks in Go1.6 ar not allowed to take Go pointers
|
Ping, and feedback on this? |
|
Looks like a reasonable approach to me, but I haven't yet had a chance to test it. |
|
I can confirm that this resolves the same issue I was having with gokogiri on FreeBSD as well as Linux. |
|
I've incorporated this into my fork, and it works fine on both 1.5 and 1.6 as far as I can tell. |
|
I should add that it’s possible to work around the runtime checks in Go 1.6 by using the |
afeld
added a commit
to opencontrol/fedramp-templater
that referenced
this pull request
May 27, 2016
|
OK, will close it, since everyone interested in a maintained package uses the fork from @jbowtie anyway 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go 1.6 it is basically forbidden to pass a Go pointer to Go functions that are used as callbacks from C.
Fix this by funneling those pointers through global variables.
Fixes #92