support optional chaining operator #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgutov
reviewed
Aug 10, 2019
| (js2-highlight-function-call (js2-current-token)) | ||
| (js2-get-token) | ||
| (let (args | ||
| (pos (js2-node-pos pn))) | ||
| (when use-optional-chaining-p |
There was a problem hiding this comment.
How come this is needed for optional chaining, but not for normal chaining?
There was a problem hiding this comment.
See https://babeljs.io/docs/en/babel-plugin-proposal-optional-chaining
So now there two types of function call node, one is Test?.(); , the other is Test()
AST is like
function call token as parent token
function name token parameters token
optional chaining token could be converted to a boolean flag in funcall call node. This flag is used when executing AST. Since js2-mode is just a parser to build the AST tree, optional chaining toke could be ignored in js2-parse-function-call
dgutov
reviewed
Aug 10, 2019
|
Could you add a NEWS entry? In NEWS.md, at the top. |
|
@dgutov , I updated pull request. |
|
updated |
dgutov
reviewed
Aug 14, 2019
| @@ -8,6 +8,10 @@ | |||
| `js2-jsx-mode`. | |||
| * Using `js2-jsx-mode` will now trigger a warning in Emacs 27. | |||
|
|
|||
| ## 2019-08-14 | |||
|
|
|||
| * Support for optional-chaining operator `?.` | |||
There was a problem hiding this comment.
Please put this under Next.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://babeljs.io/docs/en/babel-plugin-proposal-optional-chaining
and #506