Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return tracks without uri in lookup #62

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Do not return tracks without uri in lookup #62

merged 1 commit into from
Dec 10, 2015

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 29, 2015

When these are served e.g. through "lsinfo SoundCloud/Played" to
ncmpcpp, it might crash: http://bugs.musicpd.org/view.php?id=4468.

Ref: mopidy/mopidy#1340

@blueyed
Do not return tracks without uri in lookup
20d553e 
When these are served e.g. through "lsinfo SoundCloud/Played" to
ncmpcpp, it might crash: http://bugs.musicpd.org/view.php?id=4468.
@jodal jodal merged commit 20d553e into mopidy:master Dec 10, 2015
@jodal jodal self-assigned this Dec 10, 2015
@jodal
Copy link
Member

jodal commented Dec 10, 2015

Thanks! I merged this and then went on to make self.api.get_track() return None on failed lookups instead of empty Track() objects.

@blueyed blueyed deleted the fix-handling-of-removed-tracks branch December 10, 2015 15:36
@jodal jodal mentioned this pull request Jan 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jodal jodal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @jodal