Fix wrong reference that was causing go-gitea#16336

node.Attr[idx].Val is not the same as attr.Val, the latter is an independent object that won't change anything in the document
moqmar · Jul 4, 2021 · a172a91 · a172a91
1 parent fae07cb
commit a172a91
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/markup/html.go b/modules/markup/html.go
@@ -375,7 +375,7 @@ func visitNode(ctx *RenderContext, procs []processor, node *html.Node, visitText
 					}
 					prefix = strings.Replace(prefix, "/src/", "/media/", 1)
 
-					attr.Val = util.URLJoin(prefix, attr.Val)
+					node.Attr[idx].Val = util.URLJoin(prefix, attr.Val)
 				}
 			}
 		} else if node.Data == "a" {
@@ -391,7 +391,7 @@ func visitNode(ctx *RenderContext, procs []processor, node *html.Node, visitText
 				for i, class := range classes {
 					if class == "icon" {
 						classes[0], classes[i] = classes[i], classes[0]
-						attr.Val = strings.Join(classes, " ")
+						node.Attr[idx].Val = strings.Join(classes, " ")
 
 						// Remove all children of icons
 						child := node.FirstChild