Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat callback #33

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Reformat callback #33

merged 7 commits into from
Jun 20, 2024

Conversation

HDThang
Copy link
Collaborator

@HDThang HDThang commented Jun 17, 2024

Background

  • As discussed in the last PR, I removed the callback in each training script and placed it in a new module to be imported.

What does this PR do?

-Created a utility module for callback to be imported in each training script
-Moved duplicate code to utils/utils.py
-Reformatted all the training scripts to use the utility module

@HDThang HDThang added the enhancement New feature or request label Jun 17, 2024
@HDThang HDThang self-assigned this Jun 17, 2024
Copy link
Collaborator

@loctxmoreh loctxmoreh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please make sure testbench are still able to launch these script (importing still work) before merging

@HDThang
Copy link
Collaborator Author

HDThang commented Jun 20, 2024

Please make sure testbench are still able to launch these script (importing still work) before merging
Then I'll need to do some testing before merging this PR.

@HDThang HDThang merged commit 2cd847b into main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants