✨ initial prototype, not tested. #235

moban/jinja2/engine.py

@@ -53,7 +53,7 @@ def __init__(self):
     constants.TEMPLATE_ENGINE_EXTENSION, tags=["jinja2", "jinja", "jj2", "j2"]
 )
 class Engine(object):
-    def __init__(self, template_dirs, extensions=None):
+    def __init__(self, template_dirs, options=None):
         """
         Contruct a jinja2 template engine
 
@@ -73,10 +73,16 @@ def __init__(self, template_dirs, extensions=None):
                 extension for extension in JINJA2_THIRD_PARTY_EXTENSIONS
             ],  # get a copy of this global variable
         )
-        if is_extension_list_valid(extensions):
-            # because it is modified here
-            env_params["extensions"] += extensions
-        import_module_of_extension(extensions)
+        if options:
+            if options.get('extensions'):
+                if is_extension_list_valid(options['extensions']):
+                    # because it is modified here
+                    env_params["extensions"] += options['extensions']
+                    import_module_of_extension(options['extensions'])
+
+            if 'extensions' in options:
+                options.pop('extensions')
+            env_params.update(options)
         self.jj2_environment = Environment(**env_params)
         for filter_name, filter_function in FILTERS.get_all():
             self.jj2_environment.filters[filter_name] = filter_function

moban/plugins/template.py

@@ -16,14 +16,29 @@ class MobanFactory(PluginManager):
     def __init__(self):
         super(MobanFactory, self).__init__(constants.TEMPLATE_ENGINE_EXTENSION)
         self.extensions = {}
+        self.options_registry = {}
 
     def register_extensions(self, extensions):
         self.extensions.update(extensions)
 
+    def register_options(self, template_types):
+        self.options_registry.update(template_types)
+
     def get_engine(self, template_type, template_dirs, context_dirs):
-        engine_cls = self.load_me_now(template_type)
-        engine_extensions = self.extensions.get(template_type)
-        engine = engine_cls(template_dirs, engine_extensions)
+        try:
+            engine_cls = self.load_me_now(template_type)
+            engine_extensions = self.extensions.get(template_type)
+            options = dict(extensions=engine_extensions)
+        except exceptions.NoThirdPartyEngine:
+            if template_type not in self.options_registry:
+                raise
+            else:
+                custom_engine_spec = self.options_registry[template_type]
+                engine_cls = self.load_me_now(custom_engine_spec.base_type)
+                # TODO:
+                # support other jinja2 options
+                options = custom_engine_spec['options']
+        engine = engine_cls(template_dirs, options)
         return MobanEngine(
             template_dirs, context_dirs, engine
         )