Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template_types: task 2: expand the definition of template_type in targets section #234

Closed
chfw opened this issue Feb 24, 2019 · 4 comments
Closed

template_types: task 2: expand the definition of template_type in targets section #234

chfw opened this issue Feb 24, 2019 · 4 comments
Assignees
@ayan-b

Comments

@chfw
Copy link
Member

chfw commented Feb 24, 2019 •
edited
Loading

so that an ad-hoc instance of template engine will be created, used and dumped.

targets
  - a.output: a.my_new_engine
  - output: b.output
    template: b.unknown
    template_type: my_new_engine
  - output: c.output  # this will create ad-hoc jinja2 engine, and get dumped after the op.
     template: c.alien
     template_type:
      - overrides: jinja2
      - options:
        ..
        block_end_string: '*))'
        ...

#202
@chfw
Copy link
Member Author

chfw commented Feb 26, 2019

@ayan-b, would you like to take this task? this one looks like an independent one.

@ayan-b
Copy link
Member

ayan-b commented Feb 26, 2019

On it!

This was referenced Feb 26, 2019
Closed
Merged
@ayan-b ayan-b self-assigned this Feb 27, 2019
@chfw chfw mentioned this issue Feb 28, 2019
Merged
@ayan-b
Copy link
Member

ayan-b commented Feb 28, 2019

@chfw here https://github.com/moremoban/moban/blob/dev/moban/definitions.py#L50 why are we using endswith even when there is a user defined template_type?

@chfw
Copy link
Member Author

chfw commented Mar 1, 2019

Because when templating a directory, most of templates would end with .jj2, i.e. Setup.py.jj2. In this scenario, you want your output to be setup.py instead of setup.py.jj2.

ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
131d3c6 
Closes moremoban#234
@ayan-b ayan-b mentioned this issue Mar 1, 2019
Merged
ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
1954501 
Closes moremoban#234
ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
0b3ba3d 
Closes moremoban#234
ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
334081d 
Closes moremoban#234
ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
4b59c26 
Closes moremoban#234
ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
dfd151b 
Closes moremoban#234
ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
ac9bc50 
Closes moremoban#234
ayan-b added a commit to ayan-b/moban that referenced this issue Mar 1, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
3c08749 
Closes moremoban#234
@chfw chfw closed this as completed in #245 Mar 3, 2019
chfw pushed a commit that referenced this issue Mar 3, 2019
@ayan-b @chfw
Expand the definition of template_type in targets section (#245)
5133306 
* ✨ Expand the definition of template_type in targets section

Closes #234

* 📚 Update changelog

* 🔬 Add tests

* 📚 Update to using extension

Closes #90

* 📝 Use base_type instead of overrides

* 📝 Change logic to use engine temorarily

* 💄 Pump up the version

* 🔬 More tests

* 📝 Improve test format

* 📝 Update to latest syntax

* 📚 Update docs to latest syntax

* 🔬 More tests

* 📝 Address the feedback
ayan-b added a commit to ayan-b/moban that referenced this issue Apr 21, 2019
@ayan-b
✨ Expand the definition of template_type in targets section
b8505e0 
Closes moremoban#234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayan-b ayan-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chfw @ayan-b