Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error to info #151

Merged
merged 3 commits into from
Jan 5, 2019
Merged

Change error to info #151

merged 3 commits into from
Jan 5, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Jan 5, 2019

@chfw chfw requested review from CLiu13 and jayvdb January 5, 2019 17:19
@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #151 into dev will increase coverage by 0.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #151      +/-   ##
==========================================
+ Coverage   97.44%   97.89%   +0.45%     
==========================================
  Files          40       40              
  Lines        1916     1951      +35     
==========================================
+ Hits         1867     1910      +43     
+ Misses         49       41       -8
Impacted Files Coverage Δ
tests/test_utils.py 97.93% <100%> (+0.08%) ⬆️
moban/reporter.py 98.48% <100%> (+3.32%) ⬆️
...sts/integration_tests/test_command_line_options.py 98.25% <100%> (ø) ⬆️
tests/test_reporter.py 100% <100%> (ø) ⬆️
moban/plugins.py 96.5% <100%> (ø) ⬆️
tests/test_main.py 95.55% <100%> (+0.49%) ⬆️
moban/utils.py 97.94% <0%> (+2.73%) ⬆️
moban/__main__.py 66.66% <0%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0290c6...5635ce1. Read the comment docs.

Copy link
Collaborator

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chfw chfw merged commit dd78f63 into dev Jan 5, 2019
@chfw chfw deleted the change-error-to-info branch January 5, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants