Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 0.3.8 #162

Merged
merged 21 commits into from
Jan 12, 2019
Merged

release 0.3.8 #162

merged 21 commits into from
Jan 12, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Jan 11, 2019

chfw added 18 commits January 10, 2019 07:11
@chfw
🔥 replace physical fake moban-mako engine. #156
ce73e5a
@chfw
✨ use template string as an input for '-t'. resolve #154
a962097
@chfw
✨ provide short form string template. #154
f0d28a6
@chfw
🔨 code refactoring
9585cdc
@chfw
🔬 test command line options
e86fd1c
@chfw
🔬 test jinja2 engine get template from string
0e1af85
@chfw
📚 update readme
5d6470e
@chfw
📚 command options update
5c2326a
@chfw
📚 explain environment variables. resolves #155
6cfafde
@chfw
💄 update version number
7909bc9
@chfw
Merge pull request #159 from moremoban/handle-missing-template
32c14eb 
$ HELLO="world" moban "{{HELLO}}"
@chfw
📚 minor update on README
ce9e9a5
@chfw
📚 minor update on README
a0cf4df
@chfw
✨ update exit code. resolves #157. update #14.
39b544d
@chfw
✨ disable file permission related feature: permission copying and fil…
c821119 
…e changes. resolve #141
@chfw
Merge pull request #160 from moremoban/exit-code
4585474 
✨ update exit code. resolves #157. update #14.
@chfw
🤝 merge with dev branch
96be556
@chfw
📚 update change log
697f316
@codecov-io
Copy link

codecov-io commented Jan 11, 2019 •
edited
Loading

Codecov Report

Merging #162 into master will decrease coverage by 0.22%.
The diff coverage is 94.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   98.02%   97.79%   -0.23%     
==========================================
  Files          40       40              
  Lines        1970     2043      +73     
==========================================
+ Hits         1931     1998      +67     
- Misses         39       45       +6
Impacted Files Coverage Δ
tests/test_hash_store.py 100% <ø> (+1.11%) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 98.3% <100%> (+0.05%) ⬆️
tests/test_engine.py 100% <100%> (ø) ⬆️
tests/test_main.py 96.15% <100%> (+0.59%) ⬆️
tests/test_jinja2_engine.py 100% <100%> (ø) ⬆️
moban/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/plugins.py 98.08% <100%> (+0.17%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f794c20...bb8c747. Read the comment docs.

CLiu13
CLiu13 approved these changes Jan 12, 2019
View reviewed changes
Copy link
Collaborator

@CLiu13 CLiu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chfw chfw merged commit 234efa4 into master Jan 12, 2019
@jayvdb
Copy link
Member

jayvdb commented Jan 14, 2019

Packaging request done: https://build.opensuse.org/request/show/665382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwalM2212 PrajwalM2212 PrajwalM2212 approved these changes

@CLiu13 CLiu13 CLiu13 approved these changes

@jayvdb jayvdb Awaiting requested review from jayvdb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chfw @codecov-io @jayvdb @CLiu13 @PrajwalM2212