Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if git is available on non-win32 platform #255

Merged
merged 3 commits into from
Mar 8, 2019
Merged

check if git is available on non-win32 platform #255

merged 3 commits into from
Mar 8, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Mar 8, 2019

delivers #209

I am sorry for windows users who has no git. you will get stack trace. Passing shell=True to subprocess.check_output(...shell=True).. has its security risk on windows.

@chfw chfw requested review from ayan-b and CLiu13 March 8, 2019 19:46
@chfw chfw merged commit 84afbaf into dev Mar 8, 2019
@chfw chfw deleted the git-check branch March 8, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants