Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruamel-yaml pins to aid installation #285

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Jul 8, 2019

Fixes #274

Depends on #280 (merged) and moremoban/pypi-mobans#92

moremoban/pypi-mobans#90 would also be helpful but is optional.

@jayvdb jayvdb force-pushed the pin-ruamel-yaml branch 2 times, most recently from 574084c to b2a11b2 Compare July 8, 2019 16:26
@jayvdb jayvdb changed the title 🔥 add ruamel-yaml pins to aid installation add ruamel-yaml pins to aid installation Jul 8, 2019
@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #285 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #285      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files          60       60              
  Lines        2485     2482       -3     
==========================================
- Hits         2458     2455       -3     
  Misses         27       27
Impacted Files Coverage Δ
moban/utils.py 97.43% <0%> (-0.1%) ⬇️
moban/hashstore.py 100% <0%> (ø) ⬆️
tests/test_repo.py 100% <0%> (ø) ⬆️
moban/repo.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc6379...5e895b6. Read the comment docs.

@jayvdb jayvdb requested a review from chfw July 8, 2019 16:29
mobanfile Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@jayvdb jayvdb force-pushed the pin-ruamel-yaml branch 3 times, most recently from 30df19b to 43d7f8a Compare July 9, 2019 04:15
@jayvdb jayvdb changed the title add ruamel-yaml pins to aid installation (DNM) add ruamel-yaml pins to aid installation Jul 9, 2019
.moban.d/travis.yml Outdated Show resolved Hide resolved
@chfw
Copy link
Member

chfw commented Jul 11, 2019

would you like to update change log?

@jayvdb jayvdb force-pushed the pin-ruamel-yaml branch from f197920 to 2887892 Compare July 12, 2019 00:47
mobanfile Outdated Show resolved Hide resolved
Re-adds Python 3.4 support, broken by ruamel.yaml desupporting it
in version 0.15.94.
Also adds minimum version for ruamel-yaml on Python 3.7 and 3.8,
and re-adds Python 3.8-dev to the Travis matrix recently removed
in ec48af4 due to temporary build failures.

And avoids newer arrow desupported on Python 3.4.

Fixes moremoban#274
@jayvdb jayvdb force-pushed the pin-ruamel-yaml branch from 2887892 to 5e895b6 Compare July 13, 2019 02:10
@jayvdb jayvdb changed the title (DNM) add ruamel-yaml pins to aid installation add ruamel-yaml pins to aid installation Jul 13, 2019
@jayvdb
Copy link
Member Author

jayvdb commented Jul 13, 2019

Ready to roll.

I'll do relnotes on Sunday/Monday.

Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@chfw chfw merged commit 492f73e into moremoban:dev Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruamel.yaml broken on Python 3.4 and 3.8-dev
3 participants