Revert use of giturlparse #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python 3.8-dev job has broken on building ruamel.yaml, and the template doesnt provide control over allowing failures.
This substantially reverts commit 9517891. The cause of the change has been addressed by an enhancement in git-url-parse v1.2.1, too late to be included in moban v0.4.0 retr0h/git-url-parse@3e2bf91e Using giturlparse instead of git-url-parse is a non-trivial breaking change. It was done to avoid one minor regression which users could workaround, however it introduced many significant regressions users could not workaround as giturlparse does not parse many types of URLs. Closes moremoban#277
git-url-parse does not yet (1.2.2) handle trailing slashes, which are an optional part of all git URLs, but were supported before the switch to using GitPython. Closes moremoban#277
Codecov Report
@@ Coverage Diff @@
## dev #288 +/- ##
==========================================
- Coverage 98.94% 98.91% -0.03%
==========================================
Files 60 60
Lines 2550 2480 -70
==========================================
- Hits 2523 2453 -70
Misses 27 27
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
As this is another breaking change, it should be in 0.5.0 , not in 0.4.x. The entire 0.4.x series is unusable for anyone who was using
git-url-parsewith 0.3.x, and they should blacklist 0.4.x