Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 temporary fix for #105 #107

Merged
merged 1 commit into from
Jul 14, 2019
Merged

🐛 temporary fix for #105 #107

merged 1 commit into from
Jul 14, 2019

Conversation

chfw
Copy link
Member

@chfw chfw commented Jul 14, 2019

add flake8 installation back in lint.sh if custom command is make lint.

jayvdb
jayvdb approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 should be added to the tests/requirements.txt or dev-requirements.txt or something like that

@jayvdb
Copy link
Member

jayvdb commented Jul 14, 2019

Adding to lint.sh to be installed every time means lint.sh isnt useful for repo users, only CI.

Anyways, those .sh are mostly pyexcel-specific files anyway, so if this change helps you, then it isnt hurting anyone else, hence approve.

@chfw
Copy link
Member Author

chfw commented Jul 14, 2019

@jayvdb thanks. I will think about #108 and provide a refined approach.

@chfw chfw merged commit 767b412 into dev Jul 14, 2019
@chfw chfw deleted the lint-fix branch January 11, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayvdb jayvdb jayvdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @jayvdb