fix cursor check to null

[nucleartux]

fixes #10

[rt2zz]

👍 thank you!

[niftylettuce]

Can we cut another release for this? I'm testing it out today.

[niftylettuce]

@nucleartux @rt2zz still getting errors, here's a screenshot...

I'm calling getAll and this happens - I think you need to do some other stuff than just this null fix to get it to work properly. Maybe take a look at how PhoneGap/Cordova wrote their plugin? I will gladly pay if you get this working @nucleartux

[nucleartux]

Something wrong with your code(reactNativeContacts2?). Can you copy paste it here ?

[niftylettuce]

I did npm install --save rt2zz/react-native-contacts, so the code is the
same as master branch here on GitHub.
On Nov 22, 2015 1:30 AM, "Igor" notifications@github.com wrote:

Something wrong with your code(reactNativeContacts2?). Can you copy paste
it here ?

—
Reply to this email directly or view it on GitHub
#13 (comment)
.

[nucleartux]

Please try
direct call NativeModules.Contacts.getAll

[niftylettuce]

I get a lot of this console output:

[rt2zz]

I do not have an answer at the moment, but from a bigger picture the current code (which I wrote) is woefully slow, and at the very least would need to be pushed to a background thread before it could be considered usable.

I do not have a timetable for fixing this as of now, but am open to suggestions / PRs.

@niftylettuce if you are interested in paying I can probably get you in touch with someone who can hammer this out.

[niftylettuce]

please do put me in touch, its way too slow. niftylettuce@gmail.com
On Nov 22, 2015 2:26 AM, "Zack" notifications@github.com wrote:

I do not have an answer at the moment, but from a bigger picture the
current code (which I wrote) is woefully slow, and at the very least would
need to be pushed to a background thread before it could be considered
usable.

I do not have a timetable for fixing this as of now, but am open to
suggestions / PRs.

@niftylettuce https://github.com/niftylettuce if you are interested in
paying I can probably get you in touch with someone who can hammer this out.

—
Reply to this email directly or view it on GitHub
#13 (comment)
.

[niftylettuce]

@nucleartux it runs, but it's super slow, and some of the contacts come back blank -- like the nulls are never cleaned up or something? It's just super slow in general - how can we make this fast? /cc @rt2zz