React Native 0.76.0 support #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenoh149
reviewed
Oct 29, 2024
| @@ -66,7 +66,7 @@ - (NSDictionary *)constantsToExport | |||
| } else if (authStatus == CNAuthorizationStatusAuthorized){ | |||
| resolve(@"authorized"); | |||
| } else if(@available(iOS 18, *)) { | |||
| if (authStatus == CNAuthorizationStatusLimited) { | |||
| if (authStatus == PHAuthorizationStatusLimited) { | |||
There was a problem hiding this comment.
Don't you need to define PHAuthorizationStatusLimited within checkPermission?
There was a problem hiding this comment.
Oh think i did something wrong ☠️
Well i am not ios developer these are xcode suggestions so its worked in my current project with new arch so thats why i added this code.
There was a problem hiding this comment.
I'm going to close this PR since you are not an ios developer. If you are not sure then it may just make things more confusing.
|
This change sounds strange. CNContantStore return a value of CNAuthorizationStatus enum: PHAuthorizationStatusLimited is a value of another enum: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working Example (updated to react native 0.76.0)
https://github.com/SolankiYogesh/react-native-contacts/tree/example