Use exec to forward signals like SIGTERM to gunicorn #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 104 104
=========================================
Hits 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Merged
Otherwise the container cannot be shutdown orderly and will be killed after a 10sec timeout
mormahr
force-pushed
the
forward-signals
branch
from
6094561 to
72c8c1b
Compare
mormahr
reviewed
Sep 1, 2021
mormahr
approved these changes
Sep 1, 2021
|
Looks good. We should look into using tini in the future, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the container cannot be shutdown orderly and will be killed after a 10sec timeout
Also see: https://hynek.me/articles/docker-signals/