Merge pull request doctrine#3584 from ostrolucky/rem-addlogger

Remove LoggerChain::addLogger

UPGRADE.md

@@ -53,6 +53,7 @@ The `Doctrine\DBAL\Driver::getName()` has been removed.
  * Removed `Table::addUnnamedForeignKeyConstraint()` and `Table::addNamedForeignKeyConstraint()`.
  * Removed `Table::renameColumn()`.
  * Removed `SQLParserUtils::getPlaceholderPositions()`.
+ * Removed `LoggerChain::addLogger`.
  * Removed `AbstractSchemaManager::getFilterSchemaAssetsExpression()`, `Configuration::getFilterSchemaAssetsExpression()`
    and `Configuration::getFilterSchemaAssetsExpression()`.
  * `SQLParserUtils::*_TOKEN` constants made private.

lib/Doctrine/DBAL/Logging/LoggerChain.php

@@ -9,27 +9,17 @@
  */
 final class LoggerChain implements SQLLogger
 {
-    /** @var SQLLogger[] */
+    /** @var iterable<SQLLogger> */
     private $loggers = [];
 
     /**
-     * @param SQLLogger[] $loggers
+     * @param iterable<SQLLogger> $loggers
      */
-    public function __construct(array $loggers = [])
+    public function __construct(iterable $loggers = [])
     {
         $this->loggers = $loggers;
     }
 
-    /**
-     * Adds a logger in the chain.
-     *
-     * @deprecated Inject list of loggers via constructor instead
-     */
-    public function addLogger(SQLLogger $logger) : void
-    {
-        $this->loggers[] = $logger;
-    }
-
     /**
      * {@inheritdoc}
      */

tests/Doctrine/Tests/DBAL/Logging/LoggerChainTest.php

@@ -32,13 +32,10 @@ public function testStopQuery() : void
      */
     private function createChain(string $method, ...$args) : LoggerChain
     {
-        $chain = new LoggerChain([
+        return new LoggerChain([
+            $this->createLogger($method, ...$args),
             $this->createLogger($method, ...$args),
         ]);
-
-        $chain->addLogger($this->createLogger($method, ...$args));
-
-        return $chain;
     }
 
     /**