Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] add proper MonadFail instance #347

Merged
merged 2 commits into from
Nov 5, 2023
Merged

[fix] add proper MonadFail instance #347

merged 2 commits into from
Nov 5, 2023

Conversation

MangoIV
Copy link
Collaborator

@MangoIV MangoIV commented Oct 30, 2023

fixes #346

@MangoIV MangoIV marked this pull request as ready for review October 30, 2023 20:28
echatav
echatav approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@echatav echatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@echatav echatav merged commit 3107203 into morphismtech:dev Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echatav echatav echatav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MonadFail instance for PQ is self-recursive and causes an endless loop
2 participants
@MangoIV @echatav