Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang from 1.22.5-alpine to 1.23.0-alpine #139

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 14, 2024

Bumps golang from 1.22.5-alpine to 1.23.0-alpine.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps golang from 1.22.5-alpine to 1.23.0-alpine.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Aug 14, 2024
@vavsab
Copy link

vavsab commented Aug 27, 2024

@morphy2k could you please merge it? I want to upgrade golang but this blocks me.

UPD: Not needed anymore. Forked and got rid of Docker at all.
https://github.com/mapped/revive-action?tab=readme-ov-file#revive-action

@morphy2k
Copy link
Owner

morphy2k commented Aug 29, 2024

@vavsab The Go version of the Docker image should not play a role, as it is only used for building and go list. Or am I missing something?

@at-wat
Copy link

at-wat commented Aug 30, 2024

We have same issue.
I don't dig deeper yet but when the go version in go.mod is updated to go 1.23, revive-action outputs following logs and fails:

ACTION: unknown
REVIVE: 
Failures
  linting - retrieving failures channel: command go list: exit status 1
Successful run with 0 failures (0 warnings, 0 errors)

@vavsab
Copy link

vavsab commented Aug 30, 2024

@morphy2k Yes, I had the same issue as @at-wat reported above. After every Golang upgrade.

@morphy2k morphy2k merged commit a211577 into master Aug 30, 2024
1 check passed
@dependabot dependabot bot deleted the dependabot/docker/golang-1.23.0-alpine branch August 30, 2024 16:38
@morphy2k
Copy link
Owner

Merged.

This issue is caused by the last Revive release. It should be permanently fixed with the next one. See #135 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants