-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split register info class into multiple classes; one per register file #320
Conversation
I understand the intention of the change, but I'm not sure think that (as far as i understand) essentially merging multiple register infos in e.g. I'd be more in favor of |
@mortbopet This sounds good to me since returning a |
NOTE: This does not compile yet.
This makes it harder to forget to implement this map for each ISA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after these things are addressed.
Create
RegInfoInterface
as an abstract class to interface into a single register file. Return a vector of all theRegInfoInterface
s implemented by an ISA.Also refactored any code that indexes a register so that the register's file type is used in the index.
This includes the command line option
--reginit
. It now requires the register file type to be specified for each initialized register set. It can be used multiple times to initialize multiple register files. Example: