Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filename extension #1370

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Aug 5, 2022

Changes default name to have .pt. Fixes CO-850.

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner August 5, 2022 18:38
@mvpatel2000 mvpatel2000 enabled auto-merge (squash) August 5, 2022 18:39
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@mvpatel2000 mvpatel2000 merged commit 423539b into mosaicml:dev Aug 5, 2022
@ravi-mosaicml
Copy link
Contributor

Forgot to mention, but do we want the latest symlink to also have an extension?

@mvpatel2000 mvpatel2000 deleted the mvpatel2000/change-file-ext branch August 5, 2022 22:23
@mvpatel2000
Copy link
Contributor Author

Forgot to mention, but do we want the latest symlink to also have an extension?

Its in the PR -- yea I think we do so it looks like a checkpoint file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants