Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge nlp+hf notebooks #1406

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Conversation

A-Jacobson
Copy link
Contributor

by "merge" we mean delete the nlp notebook. the HF notebook does the same thing as the nlpnotebook and is now our recommended path to train with HF models.

@A-Jacobson A-Jacobson requested a review from a team as a code owner August 12, 2022 18:02
@A-Jacobson A-Jacobson requested a review from a team as a code owner August 12, 2022 18:28
@A-Jacobson A-Jacobson requested a review from alextrott16 August 12, 2022 18:42
Copy link
Contributor

@alextrott16 alextrott16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hanlint hanlint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything from the NLP notebook that we want to transfer over?

@A-Jacobson
Copy link
Contributor Author

I think we're good with this. I transferred the tensorboard logging in this pr. The only difference between the two notebooks are that this one uses the huggingfacemodel class.

@A-Jacobson A-Jacobson enabled auto-merge (squash) August 15, 2022 17:32
@hanlint hanlint disabled auto-merge August 15, 2022 20:12
@hanlint hanlint merged commit 841c026 into mosaicml:dev Aug 15, 2022
ishanashastri pushed a commit to ishanashastri/composer that referenced this pull request Aug 17, 2022
* merge nlp+hf notebooks
* update readme and docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants