Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algolia doc search #1443

Merged
merged 21 commits into from
Sep 2, 2022
Merged

Algolia doc search #1443

merged 21 commits into from
Sep 2, 2022

Conversation

nqn
Copy link
Contributor

@nqn nqn commented Aug 24, 2022

Prototype of real time search with Algolia docsearch
Screen Shot 2022-08-24 at 3 27 18 PM

Closes CO-808

@nqn nqn marked this pull request as draft August 24, 2022 22:34
Copy link
Contributor

@lupesko lupesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good beyond the small nit

docs/source/_templates/base.html Outdated Show resolved Hide resolved
@nqn
Copy link
Contributor Author

nqn commented Aug 26, 2022

There is an issue with require.min.js and load order (it messes with algolia's library). So need to resolve that before we can land this.

It is tricky, as the issue occurs once require.min.js has been cached

@nqn nqn marked this pull request as ready for review August 29, 2022 17:47
@nqn nqn changed the title Algolia doc search prototype Algolia doc search Aug 29, 2022
@bandish-shah bandish-shah merged commit cfbb15a into mosaicml:dev Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants