-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CometML Support #1490
Add CometML Support #1490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are integration tests here feasible? Ideally we'd have something set up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your Contribution. Left some comments. Also, do you have a plan to add a unit test for this change in tests/loggers/test_cometml_logger.py
?
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Ok, @karan6181, @mvpatel2000, I added a unit test. Let me know how it looks and if this PR is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ideally we get integration tests at some point soon, but that's a later issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
CO-1027
CometMLLogger
Manual/E2E Tests:
Local Custom Entrypoint
Comet results
WandB results for comparison
Local YAHP Entrypoint
CometML
WandB
Remote YAHP Entrypoint
CometML
WandB
Remote Custom Entrypoint
Remote Bert Run Results with Comet
Corresponding WandB run