-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dataloader initialize_object
to factory methods
#1510
Conversation
ready for review or wait for all checks? |
@knighton wait for all checks, thank you :) |
Added CIFAR-10 dataloader factories. Also added tests for CIFAR10 and MNIST based on Test code is especially redundant; only holding off on adding shared utils since maybe there's already a plan to replace |
Yeah we can DRY these out later. @coryMosaicML since we are dropping BRATS, can you help test the imagenet/ade20k ones to make sure nothing broke with this PR? I think just kicking off a run and making sure it successfully starts training would be sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @hanlint! This is super important for de-YAHPing because the dataset Hparams is where a lot of the "black magic" of hparams lives. Thanks for doing this. Looks pretty good to me, but I'll defer to James, who probably knows this stuff better than me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted what i think is a missing param in ade20k_hparams. otherwise lgtm! good stuff.
…o hanlin/dl_factories
This PR continues our effort to remove logic from
initialze_object
in preparation of deprecating yahp from the codebase. We move most of the logic into factory methods, e.g.:TODO:
Need some help to complete the rest!