Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIoU metric when self.total_union==0 #1558

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

abhi-mosaic
Copy link
Contributor

@abhi-mosaic abhi-mosaic commented Sep 26, 2022

@mvpatel2000 Could you try this branch out with DeepLabV3 and let me know if it fixes the issue you were seeing?

Fixes CO-1118

@mvpatel2000 mvpatel2000 marked this pull request as ready for review September 26, 2022 04:15
@mvpatel2000 mvpatel2000 requested a review from a team as a code owner September 26, 2022 04:15
@mvpatel2000
Copy link
Contributor

LGTM, fixes NaNs (runs). Will defer to Cory or Landan for approval

composer/metrics/metrics.py Outdated Show resolved Hide resolved
@Landanjs
Copy link
Contributor

I will try running this, thank you for fixing my bug!

Copy link
Contributor

@Landanjs Landanjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvpatel2000 mvpatel2000 merged commit 1378466 into mosaicml:dev Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants