Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLU Fixes #1564

Merged
merged 4 commits into from
Sep 28, 2022
Merged

GLU Fixes #1564

merged 4 commits into from
Sep 28, 2022

Conversation

mvpatel2000
Copy link
Contributor

Some quality of life improvements:

  • does not error out if GLU is applied more than once, and instead a warning is emitted
  • improvements to error messages to be more clear

alextrott16
alextrott16 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@alextrott16 alextrott16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvpatel2000 mvpatel2000 merged commit 7db8a99 into mosaicml:dev Sep 28, 2022
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/glu branch September 28, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskhudia dskhudia dskhudia approved these changes

@alextrott16 alextrott16 alextrott16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvpatel2000 @alextrott16 @dskhudia