Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MLPerfCallback for v2.1 #1607

Merged
merged 14 commits into from
Oct 11, 2022
Merged

Conversation

hanlint
Copy link
Contributor

@hanlint hanlint commented Oct 8, 2022

What does this PR do?

Updates the MLPerfCallback by adding bert support, and updating the MLperf compliance checker to the v2.1 ruleset. Also fixes the tests to be passing.

Detailed fixes to MLPerfCallback:

  • train_samples is now logged properly when using IterableDataset, which has a per-device length.
  • the BERT benchmark logs time in units of samples, whereas resnet logs in epochs
  • uploading the results files now occurs at the end of every eval step, and also when the callback is closed.
  • adds option exit_at_target to exit training when target is met. Default: False

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Copy link
Contributor

@dskhudia dskhudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment because I just merged #1601

composer/callbacks/mlperf.py Outdated Show resolved Hide resolved
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanlint hanlint enabled auto-merge (squash) October 11, 2022 15:56
@hanlint hanlint merged commit 50253c1 into mosaicml:dev Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants