When model is not on meta device, initialization should occur on compute device not CPU
#1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcui19
approved these changes
Oct 14, 2022
abhi-mosaic
force-pushed
the
abhi/fsdp_bugfix_0_11
branch
from
e444327 to
3247944
Compare
bandish-shah
changed the title
meta device, initialization should occur on compute device not CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue related to when CPU initialized models are passed to the Trainer and used with FSDP.
It also changes some of the internal key values to be upper case to match the existing FSDP conventions.
Finally,
min_paramsis now set to1e9by default so that it does not interfere with most models.Closes CO-1256, CO-1259