Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trainer arg for engine passes #1673

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Add trainer arg for engine passes #1673

merged 3 commits into from
Oct 24, 2022

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

As title. Also adds tests.

What issue(s) does this change relate to?

CO-980

@mvpatel2000 mvpatel2000 mentioned this pull request Oct 24, 2022
Closed
dakinggg
dakinggg approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple documentation requests, otherwise LGTM.

composer/trainer/trainer.py Outdated Show resolved Hide resolved
composer/core/engine.py Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 merged commit 2b949b0 into mosaicml:dev Oct 24, 2022
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/engine2 branch October 24, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@hanlint hanlint Awaiting requested review from hanlint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg