Clear the Optimizer before wrapping with FSDP #1732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If a model is created on device 'cpu' instead of 'meta,' the optimizer holds references to unsharded modules on GPU, thus causing the GPU to OOM when a model could fit onto memory.
We now clear the optimizer param groups and states before wrapping the model with FSDP.
Testing
Link to the gist where we now OOM on the forwards pass but not in the model wrapping:
https://gist.github.com/bcui19/c972aa2743e2149baf631b5f71a9fae8
What issue(s) does this change relate to?
Fixes CO-1409
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)